Messages in this thread | | | Subject | Re: [PATCH] kernel: acctc.c: Fixed else if not generally userful after a break or return warning | From | Joe Perches <> | Date | Wed, 24 Sep 2014 22:05:46 -0700 |
| |
On Thu, 2014-09-25 at 06:00 +0100, Al Viro wrote: > It's not you, it's checkpatch.pl plus the fairly common tendency to give > that thing a lot more respect than it deserves... > > Basically, it's OK as a tool that draws ones attention to a subset of > code that might or might not be worth looking at; it gives both false > positives and false negatives and as long as there's not too much of those, > it's useful. Provided that it does *not* replace one's taste. I.e. "hey, > it points to these lines; let's take a look, some of those might be > worth some attention", rather than "The Most Holy Oracle Has Spoken; > Do What It Says".
Just so.
| |