lkml.org 
[lkml]   [2014]   [Sep]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] kernel: acctc.c: Fixed else if not generally userful after a break or return warning
On Thu, Sep 25, 2014 at 12:34:11AM -0400, Elshad Mustafayev wrote:
> I am sorry if I disturbed you. I just follow the steps in kernel newbies to
> get me in kernel development.

It's not you, it's checkpatch.pl plus the fairly common tendency to give
that thing a lot more respect than it deserves...

Basically, it's OK as a tool that draws ones attention to a subset of
code that might or might not be worth looking at; it gives both false
positives and false negatives and as long as there's not too much of those,
it's useful. Provided that it does *not* replace one's taste. I.e. "hey,
it points to these lines; let's take a look, some of those might be
worth some attention", rather than "The Most Holy Oracle Has Spoken;
Do What It Says".


\
 
 \ /
  Last update: 2014-09-25 07:41    [W:0.045 / U:0.896 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site