Messages in this thread Patch in this message | | | From | Thomas Petazzoni <> | Subject | [PATCH] char: misc: assign file->private_data in all cases | Date | Fri, 21 Jun 2013 15:01:05 +0200 |
| |
In fa1f68db6ca ("drivers: misc: pass miscdevice pointer via file private data"), the misc driver infrastructure was changed to assigned file->private_data as a pointer to the 'struct miscdevice' that corresponds to the device being opened.
However, this assignment was only done when the misc driver was declaring a driver-specific ->open() operation in its file_operations. This doesn't make sense, as the driver may not necessarily have a custom ->open() operation, and might still be interested in having file->private_data properly set for use in its ->read() and write() operations.
Therefore, we move the assignment of file->private_data outside of the condition that tests whether a driver-specific ->open() operation was defined.
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- drivers/char/misc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/char/misc.c b/drivers/char/misc.c index 190d442..fd504d3 100644 --- a/drivers/char/misc.c +++ b/drivers/char/misc.c @@ -143,8 +143,8 @@ static int misc_open(struct inode * inode, struct file * file) err = 0; old_fops = file->f_op; file->f_op = new_fops; + file->private_data = c; if (file->f_op->open) { - file->private_data = c; err=file->f_op->open(inode,file); if (err) { fops_put(file->f_op); -- 1.8.1.2
| |