Messages in this thread | | | Date | Mon, 24 Jun 2013 15:26:42 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] char: misc: assign file->private_data in all cases |
| |
On Fri, Jun 21, 2013 at 03:01:05PM +0200, Thomas Petazzoni wrote: > In fa1f68db6ca ("drivers: misc: pass miscdevice pointer via file > private data"), the misc driver infrastructure was changed to assigned > file->private_data as a pointer to the 'struct miscdevice' that > corresponds to the device being opened. > > However, this assignment was only done when the misc driver was > declaring a driver-specific ->open() operation in its > file_operations. This doesn't make sense, as the driver may not > necessarily have a custom ->open() operation, and might still be > interested in having file->private_data properly set for use in its > ->read() and write() operations. > > Therefore, we move the assignment of file->private_data outside of the > condition that tests whether a driver-specific ->open() operation was > defined.
Does this solve a problem with an existing misc driver? Or are you just trying to be "safe" for future, broken, drivers?
thanks,
greg k-h
| |