Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] char: misc: assign file->private_data in all cases | Date | Fri, 21 Jun 2013 15:25:06 +0200 |
| |
On Friday 21 June 2013, Thomas Petazzoni wrote: > n fa1f68db6ca ("drivers: misc: pass miscdevice pointer via file > private data"), the misc driver infrastructure was changed to assigned > file->private_data as a pointer to the 'struct miscdevice' that > corresponds to the device being opened. > > However, this assignment was only done when the misc driver was > declaring a driver-specific ->open() operation in its > file_operations. This doesn't make sense, as the driver may not > necessarily have a custom ->open() operation, and might still be > interested in having file->private_data properly set for use in its > ->read() and write() operations. > > Therefore, we move the assignment of file->private_data outside of the > condition that tests whether a driver-specific ->open() operation was > defined. > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Acked-by: Arnd Bergmann <arnd@arndb.de>
| |