Messages in this thread | | | Date | Mon, 21 Jul 2008 21:51:13 -0700 | From | Jeremy Fitzhardinge <> | Subject | Re: [PATCH] x86: fix pte_flags() to only return flags, fix lguest. |
| |
Stephen Rothwell wrote: > Just a small point: You don't actually need the _AC() because this is > already in a #ifndef __ASSEMBLY__ section of the file. But better safe > than sorry, I guess. :-) >
It's doubly wrong anyway. The correct thing to use here would be _AT(pteval_t, 0x80....FFF), but even more correct to use PTE_MASK which is already defined to have precisely this meaning.
J
| |