[lkml]   [2008]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
    SubjectRe: [PATCH 1/2] x86: rename PTE_MASK to PTE_PFN_MASK
    Jeremy Fitzhardinge <> writes:

    > Rusty, in his peevish way, complained that macros defining constants
    > should have a name which somewhat accurately reflects the actual
    > purpose of the constant.
    > Aside from the fact that PTE_MASK gives no clue as to what's actually
    > being masked, and is misleadingly similar to the functionally entirely
    > different PMD_MASK, PUD_MASK and PGD_MASK, I don't really see what the
    > problem is.

    PTE_PFN_MASK is not symmetric to PAGE_MASK. How about PTE_PROT_MASK?


     \ /
      Last update: 2008-07-22 15:07    [W:0.018 / U:281.296 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site