Messages in this thread | | | From | Rusty Russell <> | Subject | Re: [PATCH] x86: fix pte_flags() to only return flags, fix lguest. | Date | Tue, 22 Jul 2008 14:52:41 +1000 |
| |
On Tuesday 22 July 2008 14:38:00 Stephen Rothwell wrote: > Hi Rusty, > > On Tue, 22 Jul 2008 14:31:58 +1000 Rusty Russell <rusty@rustcorp.com.au> wrote: > > +/* This belongs in pgtable.h, but our includes are too much of a mess. > > */ +#if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE) > > +#define PTE_FLAGS _AC(0x8000000000000FFF, ULL) > > Just a small point: You don't actually need the _AC() because this is > already in a #ifndef __ASSEMBLY__ section of the file. But better safe > than sorry, I guess. :-)
Ah, yes, I had them in pgtable.h before I gave up. I'll leave it in: if someone wants them in asm they can now safely move it.
Thanks, Rusty.
| |