lkml.org 
[lkml]   [2008]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] x86: fix pte_flags() to only return flags, fix lguest.
Date
On Tuesday 22 July 2008 14:38:00 Stephen Rothwell wrote:
> Hi Rusty,
>
> On Tue, 22 Jul 2008 14:31:58 +1000 Rusty Russell <rusty@rustcorp.com.au>
wrote:
> > +/* This belongs in pgtable.h, but our includes are too much of a mess.
> > */ +#if defined(CONFIG_X86_64) || defined(CONFIG_X86_PAE)
> > +#define PTE_FLAGS _AC(0x8000000000000FFF, ULL)
>
> Just a small point: You don't actually need the _AC() because this is
> already in a #ifndef __ASSEMBLY__ section of the file. But better safe
> than sorry, I guess. :-)

Ah, yes, I had them in pgtable.h before I gave up. I'll leave it in: if
someone wants them in asm they can now safely move it.

Thanks,
Rusty.


\
 
 \ /
  Last update: 2008-07-22 07:25    [W:0.119 / U:1.168 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site