lkml.org 
[lkml]   [2007]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [Patch 05/16] Remove unnecessary kmalloc casts in the drivers subdirectory.
jack@hawkeye.stone.uk.eu.org wrote:
> --- a/drivers/char/tty_io.c
> +++ b/drivers/char/tty_io.c
> @@ -2034,7 +2034,7 @@ static int init_dev(struct tty_driver *d
> }
>
> if (!*tp_loc) {
> - tp = (struct ktermios *) kmalloc(sizeof(struct ktermios),
> + tp = kmalloc(sizeof(struct ktermios),
> GFP_KERNEL);
> if (!tp)
> goto free_mem_out;
>

Looks like you can pull the "GFP_KERNEL);" into the same line as the
kmalloc. IMO a cleanup patch shouldn't leave inexplicable linebreaks
and other whitespace strangeness behind.
--
Stefan Richter
-=====-=-=== =--- ----=
http://arcgraph.de/sr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2007-08-01 02:57    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site