Messages in this thread | | | From | Christian Borntraeger <> | Subject | Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem. | Date | Tue, 31 Jul 2007 15:53:28 +0200 |
| |
Am Dienstag, 31. Juli 2007 schrieb jack@hawkeye.stone.uk.eu.org: > --- a/drivers/pci/rom.c > +++ b/drivers/pci/rom.c > @@ -185,7 +185,7 @@ void __iomem *pci_map_rom_copy(struct pc > IORESOURCE_ROM_BIOS_COPY)) > return rom; > > - res->start = (unsigned long)kmalloc(*size, GFP_KERNEL); > + res->start = kmalloc(*size, GFP_KERNEL);
This looks wrong. void * doesnt need a cast to a pointer, but res->start is an integer u32 type, and therefore we need a cast, no?
-- IBM Deutschland Entwicklung GmbH Vorsitzender des Aufsichtsrats: Martin Jetter Geschäftsführung: Herbert Kircher Sitz der Gesellschaft: Böblingen Registergericht: Amtsgericht Stuttgart, HRB 243294
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |