lkml.org 
[lkml]   [2007]   [Jul]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [Patch 08/16] Remove unnecessary kmalloc casts in the parisc drivers.
Date
Am Dienstag, 31. Juli 2007 schrieb jack@hawkeye.stone.uk.eu.org:
> - a = (unsigned long)kmalloc(sizeof(struct irt_entry) * num_entries + 8,
GFP_KERNEL);
> + a = kmalloc(sizeof(struct irt_entry) * num_entries + 8, GFP_KERNEL);

NAK.
Same as in some other patches.
"void *" -> "ulong" is not auto casted and will give you a "warning:
assignment makes integer from pointer without a cast".

Christian
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-31 16:09    [from the cache]
©2003-2014 Jasper Spaans. Advertise on this site