Messages in this thread | | | Date | Tue, 31 Jul 2007 13:19:23 -0700 (PDT) | Subject | Re: [Patch 09/16] Remove unnecessary kmalloc casts in the pci subsystem. | From | David Miller <> |
| |
From: Christian Borntraeger <borntraeger@de.ibm.com> Date: Tue, 31 Jul 2007 15:53:28 +0200
> Am Dienstag, 31. Juli 2007 schrieb jack@hawkeye.stone.uk.eu.org: > > --- a/drivers/pci/rom.c > > +++ b/drivers/pci/rom.c > > @@ -185,7 +185,7 @@ void __iomem *pci_map_rom_copy(struct pc > > IORESOURCE_ROM_BIOS_COPY)) > > return rom; > > > > - res->start = (unsigned long)kmalloc(*size, GFP_KERNEL); > > + res->start = kmalloc(*size, GFP_KERNEL); > > This looks wrong. void * doesnt need a cast to a pointer, but res->start is an > integer u32 type, and therefore we need a cast, no?
Similar issue with the arch/sparc/kernel/ebus.c change.
If the cast is being done to an integer type you can't remove it. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |