lkml.org 
[lkml]   [2005]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2.6.11-rc2 21/29] ide: Merge do_rw_taskfile() and flagged_taskfile().
On Wed, 2 Feb 2005 12:06:03 +0900, Tejun Heo <tj@home-tj.org> wrote:
> > 21_ide_do_taskfile.patch
> >
> > Merged do_rw_taskfile() and flagged_taskfile() into
> > do_taskfile(). During the merge, the following changes took
> > place.
> > 1. flagged taskfile now honors HOB feature register.
> > (do_rw_taskfile() did write to HOB feature.)
> > 2. No do_rw_taskfile() HIHI check on select register. Except
> > for the DEV bit, all bits are honored.
> > 3. Uses taskfile->data_phase to determine if dma trasfer is
> > requested. (do_rw_taskfile() directly switched on
> > taskfile->command for all dma commands)
>
> Signed-off-by: Tejun Heo <tj@home-tj.org>

do_rw_taskfile() is going to be used by fs requests once
__ide_do_rw_disk() is converted to taskfile transport.

I don't think that do_rw_taskfile() and flagged_taskfile() merge
is a good thing as it adds unnecessary overhead for hot path
(fs requests).
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:10    [W:1.340 / U:0.032 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site