Messages in this thread | | | Date | Fri, 4 Feb 2005 03:22:09 +0100 | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 2.6.11-rc2 26/29] ide: map ide_cmd_ioctl() to ide_taskfile_ioctl() |
| |
On Fri, 04 Feb 2005 11:11:57 +0900, Tejun Heo <tj@home-tj.org> wrote: > Bartlomiej Zolnierkiewicz wrote: > > On Wed, 2 Feb 2005 12:10:37 +0900, Tejun Heo <tj@home-tj.org> wrote: > > > >>>26_ide_taskfile_cmd_ioctl.patch > >>> > >>> ide_cmd_ioctl() converted to use ide_taskfile_ioctl(). This > >>> is the last user of REQ_DRIVE_CMD. > > > > > > ide_cmd_ioctl() needs to map to taskfile transport not ide_taskfile_ioctl() > > > > > >>Index: linux-ide-export/drivers/ide/ide-iops.c > >>=================================================================== > >>--- linux-ide-export.orig/drivers/ide/ide-iops.c 2005-02-02 10:28:04.466320918 +0900 > >>+++ linux-ide-export/drivers/ide/ide-iops.c 2005-02-02 10:28:07.406843817 +0900 > >>@@ -648,11 +648,11 @@ u8 eighty_ninty_three (ide_drive_t *driv > >> > >> EXPORT_SYMBOL(eighty_ninty_three); > >> > >>-int ide_ata66_check (ide_drive_t *drive, ide_task_t *args) > >>+int ide_ata66_check (ide_drive_t *drive, task_ioreg_t *regs) > > > > > > nitpick: int ide_ata66_check() > > > > meaning...?
silly minor nitpick - please drop extra space while at it: int ide_ata66_check(ide_drive_t *drive, task_ioreg_t *regs)
> > > >> { > >>- if ((args->tfRegister[IDE_COMMAND_OFFSET] == WIN_SETFEATURES) && > >>- (args->tfRegister[IDE_SECTOR_OFFSET] > XFER_UDMA_2) && > >>- (args->tfRegister[IDE_FEATURE_OFFSET] == SETFEATURES_XFER)) { > >>+ if ((regs[IDE_COMMAND_OFFSET] == WIN_SETFEATURES) && > >>+ (regs[IDE_SECTOR_OFFSET] > XFER_UDMA_2) && > >>+ (regs[IDE_FEATURE_OFFSET] == SETFEATURES_XFER)) { > > > > > > nitpick: please drop brackets > > > > Parenthese?
doh, yes
> > > >> #ifndef CONFIG_IDEDMA_IVB > >> if ((drive->id->hw_config & 0x6000) == 0) { > >> #else /* !CONFIG_IDEDMA_IVB */ > >>@@ -678,11 +678,11 @@ int ide_ata66_check (ide_drive_t *drive, > >> * 1 : Safe to update drive->id DMA registers. > >> * 0 : OOPs not allowed. > >> */ > >>-int set_transfer (ide_drive_t *drive, ide_task_t *args) > >>+int set_transfer (ide_drive_t *drive, task_ioreg_t *regs) > > > > > > nitpick: int set_transfer() > > > > ??
extra space
> > > >> { > >>- if ((args->tfRegister[IDE_COMMAND_OFFSET] == WIN_SETFEATURES) && > >>- (args->tfRegister[IDE_SECTOR_OFFSET] >= XFER_SW_DMA_0) && > >>- (args->tfRegister[IDE_FEATURE_OFFSET] == SETFEATURES_XFER) && > >>+ if ((regs[IDE_COMMAND_OFFSET] == WIN_SETFEATURES) && > >>+ (regs[IDE_SECTOR_OFFSET] >= XFER_SW_DMA_0) && > >>+ (regs[IDE_FEATURE_OFFSET] == SETFEATURES_XFER) && > > > > > > nitpick: brackets > > > > Parentheses?
yep - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |