Messages in this thread | | | Date | Thu, 3 Feb 2005 18:46:00 +0100 | From | Bartlomiej Zolnierkiewicz <> | Subject | Re: [PATCH 2.6.11-rc2 25/29] ide: convert REQ_DRIVE_CMD to REQ_DRIVE_TASKFILE |
| |
On Wed, 2 Feb 2005 12:15:59 +0900, Tejun Heo <tj@home-tj.org> wrote: > > 25_ide_taskfile_cmd.patch > > > > All in-kernel REQ_DRIVE_CMD users except for ide_cmd_ioctl() > > converted to use REQ_DRIVE_TASKFILE. > > Signed-off-by: Tejun Heo <tj@home-tj.org> > > Index: linux-ide-export/drivers/ide/ide-disk.c > =================================================================== > --- linux-ide-export.orig/drivers/ide/ide-disk.c 2005-02-02 10:28:06.527986413 +0900 > +++ linux-ide-export/drivers/ide/ide-disk.c 2005-02-02 10:28:07.204876587 +0900 > @@ -750,7 +750,7 @@ static int set_multcount(ide_drive_t *dr > if (drive->special.b.set_multmode) > return -EBUSY; > ide_init_drive_cmd (&rq); > - rq.flags = REQ_DRIVE_CMD; > + rq.flags = REQ_DRIVE_TASKFILE;
Please instead fix ide_init_drive_cmd() to set REQ_DRIVE_TASKFILE and add set REQ_DRIVE_CMD only in ide_cmd_ioctl().
> drive->mult_req = arg; > drive->special.b.set_multmode = 1; > (void) ide_do_drive_cmd (drive, &rq, ide_wait); > Index: linux-ide-export/drivers/ide/ide.c > =================================================================== > --- linux-ide-export.orig/drivers/ide/ide.c 2005-02-02 10:27:14.652402828 +0900 > +++ linux-ide-export/drivers/ide/ide.c 2005-02-02 10:28:07.205876425 +0900 > @@ -1255,6 +1255,7 @@ static int set_pio_mode (ide_drive_t *dr > if (drive->special.b.set_tune) > return -EBUSY; > ide_init_drive_cmd(&rq); > + rq.flags = REQ_DRIVE_TASKFILE; > drive->tune_req = (u8) arg; > drive->special.b.set_tune = 1; > (void) ide_do_drive_cmd(drive, &rq, ide_wait); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |