lkml.org 
[lkml]   [1998]   [Jul]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: inodes are not cleared!
David S. Miller wrote:
>
> But in the case of i_flag, it's apparently a required field for the
> VFS functions being used by the networking layer, so networking
> needs to give it a correct value.
>
> This is a layering violation.

Typically when filesystem uses get_empty_inode, it installs the value
from the superblock s_flags fields into i_flags, so that the inodes
inherit the properties from the superblock.

For networks there's no formal superblock, but conceivably you could
define network namespaces that could use them. Or the i_flags might be
useful to networking in some way.

But it's hardly worth arguing about; if you feel that strongly about it,
send Linus a patch for get_empty_inode(). One extra cleared field isn't
going to hurt performance.

Regards,
Bill

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.altern.org/andrebalsa/doc/lkml-faq.html

\
 
 \ /
  Last update: 2005-03-22 13:43    [W:0.093 / U:1.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site