| From | Linus Walleij <> | Date | Mon, 6 May 2024 08:49:25 +0200 | Subject | Re: [RFT PATCH v2 47/48] drm/panel: sony-acx565akm: Don't call disable at remove |
| |
On Fri, May 3, 2024 at 11:38 PM Douglas Anderson <dianders@chromiumorg> wrote:
> It's the responsibility of a correctly written DRM modeset driver to > call drm_atomic_helper_shutdown() at shutdown time and that should be > disabling / unpreparing the panel if needed. Panel drivers shouldn't > be calling these functions themselves. > > A recent effort was made to fix as many DRM modeset drivers as > possible [1] [2] [3] and most drivers are fixed now. > > A grep through mainline for compatible strings used by this driver > indicates that it is used by TI OMAP boards. The TI OMAP driver > appears to be correctly calling drm_atomic_helper_shutdown() so we can > remove the calls. > > [1] https://lore.kernel.org/r/20230901234015.566018-1-dianders@chromium.org > [2] https://lore.kernel.org/r/20230901234202.566951-1-dianders@chromium.org > [3] https://lore.kernel.org/r/20230921192749.1542462-1-dianders@chromium.org > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Sebastian Reichel <sebastian.reichel@collabora.com> > Signed-off-by: Douglas Anderson <dianders@chromium.org>
|