lkml.org 
[lkml]   [2024]   [May]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [RFT PATCH v2 31/48] drm/panel: xinpeng-xpp055c272: Don't call unprepare+disable at shutdown/remove
    Date
    Am Freitag, 3. Mai 2024, 23:33:12 CEST schrieb Douglas Anderson:
    > It's the responsibility of a correctly written DRM modeset driver to
    > call drm_atomic_helper_shutdown() at shutdown time and that should be
    > disabling / unpreparing the panel if needed. Panel drivers shouldn't
    > be calling these functions themselves.
    >
    > A recent effort was made to fix as many DRM modeset drivers as
    > possible [1] [2] [3] and most drivers are fixed now.
    >
    > A grep through mainline for compatible strings used by this driver
    > indicates that it is used by Rockchip boards. The Rockchip driver
    > appears to be correctly calling drm_atomic_helper_shutdown() so we can
    > remove the calls.
    >
    > [1] https://lore.kernel.org/r/20230901234015.566018-1-dianders@chromium.org
    > [2] https://lore.kernel.org/r/20230901234202.566951-1-dianders@chromium.org
    > [3] https://lore.kernel.org/r/20230921192749.1542462-1-dianders@chromium.org
    >
    > Cc: "Heiko Stübner" <heiko@sntech.de>
    > Signed-off-by: Douglas Anderson <dianders@chromium.org>

    the underlying setup (rockchip-drm with dw-dsi) as well as the
    change itself is similar to the ltk050h3146w variant, so I don't
    see how this should behave differently ;-)

    Reviewed-by: Heiko Stuebner <heiko@sntech.de>



    \
     
     \ /
      Last update: 2024-05-27 18:17    [W:6.138 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site