lkml.org 
[lkml]   [2024]   [May]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[RFT PATCH v2 46/48] drm/panel: sony-acx565akm: Don't double-check enabled state in disable
    Date
    As talked about in commit d2aacaf07395 ("drm/panel: Check for already
    prepared/enabled in drm_panel"), we want to remove needless code from
    panel drivers that was storing and double-checking the
    prepared/enabled state. Even if someone was relying on the
    double-check before, that double-check is now in the core and not
    needed in individual drivers.

    The acx565akm seems to do some unique stuff with the "enabled"
    state. Specifically:
    1. It seems to detect the enabled state based on how the bootloader
    left the panel.
    2. It uses the enabled state to prevent certain sysfs files from
    accessing a disabled panel.

    We'll leave the "enabled" state tracking for this. However, we can at
    least get rid of the double-check when trying to disable.

    Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
    Cc: Sebastian Reichel <sebastian.reichel@collabora.com>
    Signed-off-by: Douglas Anderson <dianders@chromium.org>
    ---

    Changes in v2:
    - Split removal of prepared/enabled from handling of remove/shutdown.

    drivers/gpu/drm/panel/panel-sony-acx565akm.c | 3 ---
    1 file changed, 3 deletions(-)

    diff --git a/drivers/gpu/drm/panel/panel-sony-acx565akm.c b/drivers/gpu/drm/panel/panel-sony-acx565akm.c
    index 3d6a286056a0..a9a545a56404 100644
    --- a/drivers/gpu/drm/panel/panel-sony-acx565akm.c
    +++ b/drivers/gpu/drm/panel/panel-sony-acx565akm.c
    @@ -454,9 +454,6 @@ static int acx565akm_power_on(struct acx565akm_panel *lcd)

    static void acx565akm_power_off(struct acx565akm_panel *lcd)
    {
    - if (!lcd->enabled)
    - return;
    -
    acx565akm_set_display_state(lcd, 0);
    acx565akm_set_sleep_mode(lcd, 1);
    lcd->enabled = false;
    --
    2.45.0.rc1.225.g2a3ae87e7f-goog

    \
     
     \ /
      Last update: 2024-05-27 18:15    [W:8.078 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site