lkml.org 
[lkml]   [2024]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] staging: bcm2835-audio: add terminating new line to Kconifg
Hi,

On Wed, 13 Mar 2024 at 15:47, Dan Carpenter <dan.carpenter@linaro.org> wrote:
> Why does this make a difference? Is it just because it's annoying to
> cat a file that doesn't have a newline at the end?

* It's not just #PetPeeve. I'm trying to fix parsing errors reported
by the config-kernel tool[1], so that users can view all CONFIG
attributes without errors.

> I checked, and it's not a checkpatch warning. Perhaps it should be though.
> KTODO: make checkpatch.pl warn about files that don't end in a newline

* I'll take a look at checkpatch.pl.

> subject but he's on vacation... s/Kconifg/Kconfig/
> Just fix the subject and add a line to the commit message and I'll ack the patch.

* Okay, will send a revised patch.

Thank you.
---
- Prasad
[1] https://github.com/pjps/config-kernel


\
 
 \ /
  Last update: 2024-03-13 12:14    [W:0.037 / U:3.384 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site