lkml.org 
[lkml]   [2024]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v2] staging: bcm2835-audio: add terminating new line to Kconifg
Hello Dan,

On Wed, 13 Mar 2024 at 17:24, Dan Carpenter <dan.carpenter@linaro.org> wrote:
> I wasn't able to get it to enable the CONFIG_NO_HZ_FULL.

* CONFIG_ prefix is not required.

> ~/config-kernel/configk -e NO_HZ_FULL -c .config .

* This command works. It writes informatory logs to stderr. It helps
to redirect stderr to a log file.
Enable option:
NO_HZ_FULL
NO_HZ_COMMON
TICK_ONESHOT
RCU_NOCB_CPU
VIRT_CPU_ACCOUNTING_GEN
VIRT_CPU_ACCOUNTING
CONTEXT_TRACKING_USER
CONTEXT_TRACKING
IRQ_WORK
CPU_ISOLATION

* To see enable/disable/toggle options in action, a command below
(without -c .config) could make it easier perhaps.

$ ~/config-kernel/configk -e NO_HZ_FULL=[y/n/m] <linux-directory>
| less -r

> I'm going Ack your patch because adding a newline is the correct thing
> but you should probably also change configk to handle that.

* ie. Handle files not terminating with a newline? There are not as
many such files. Besides I agree having files terminate with a newline
is good. It makes all lines/records of consistent format, otherwise
the very last line/record becomes a special case.

Thank you.
---
- Prasad


\
 
 \ /
  Last update: 2024-03-13 18:58    [W:0.028 / U:0.440 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site