Messages in this thread | | | Date | Wed, 13 Mar 2024 13:17:39 +0300 | From | Dan Carpenter <> | Subject | Re: [PATCH v2] staging: bcm2835-audio: add terminating new line to Kconifg |
| |
Normally, I would let Greg decide to notice or ignore the typo in the subject but he's on vacation... s/Kconifg/Kconfig/
On Wed, Mar 13, 2024 at 02:42:59PM +0530, Prasad Pandit wrote: > From: Prasad Pandit <pjp@fedoraproject.org> > > Add terminating new line to the Kconfig file.
Why does this make a difference? Is it just because it's annoying to cat a file that doesn't have a newline at the end? I checked, and it's not a checkpatch warning. Perhaps it should be though.
KTODO: make checkpatch.pl warn about files that don't end in a newline
Since you're resending anyway could you add that information to the commit message? Something like: "Add terminating new line to the Kconfig file. Otherwise it's annoying to cat files that don't have a newline. #PetPeeve".
Just fix the subject and add a line to the commit message and I'll ack the patch.
regards, dan carpenter
| |