lkml.org 
[lkml]   [2024]   [Mar]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging: bcm2835-audio: add terminating new line to Kconifg
Normally, I would let Greg decide to notice or ignore the typo in the
subject but he's on vacation... s/Kconifg/Kconfig/

On Wed, Mar 13, 2024 at 02:42:59PM +0530, Prasad Pandit wrote:
> From: Prasad Pandit <pjp@fedoraproject.org>
>
> Add terminating new line to the Kconfig file.

Why does this make a difference? Is it just because it's annoying to
cat a file that doesn't have a newline at the end? I checked, and it's
not a checkpatch warning. Perhaps it should be though.

KTODO: make checkpatch.pl warn about files that don't end in a newline

Since you're resending anyway could you add that information to the
commit message? Something like: "Add terminating new line to the
Kconfig file. Otherwise it's annoying to cat files that don't have a
newline. #PetPeeve".

Just fix the subject and add a line to the commit message and I'll ack
the patch.

regards,
dan carpenter


\
 
 \ /
  Last update: 2024-03-13 11:17    [W:0.041 / U:2.388 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site