Messages in this thread Patch in this message | | | From | Mark Hasemeyer <> | Subject | [PATCH v4 12/24] arm64: dts: mediatek: mt8195: Enable cros-ec-spi as wake source | Date | Tue, 2 Jan 2024 14:07:36 -0700 |
| |
The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined.
Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake.
Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source.
Signed-off-by: Mark Hasemeyer <markhas@chromium.org> ---
(no changes since v3)
Changes in v3: -Update commit message to provide details of the motivation behind the change
Changes in v2: -Split by arch/soc
arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi index bbdcd441c049d..2edb270d0bc2f 100644 --- a/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8195-cherry.dtsi @@ -1149,6 +1149,7 @@ cros_ec: ec@0 { pinctrl-names = "default"; pinctrl-0 = <&cros_ec_int>; spi-max-frequency = <3000000>; + wakeup-source; keyboard-backlight { compatible = "google,cros-kbd-led-backlight"; -- 2.43.0.472.g3155946c3a-goog
| |