Messages in this thread Patch in this message | | | From | Mark Hasemeyer <> | Subject | [PATCH v4 11/24] arm64: dts: mediatek: mt8192: Enable cros-ec-spi as wake source | Date | Tue, 2 Jan 2024 14:07:35 -0700 |
| |
The cros_ec driver currently assumes that cros-ec-spi compatible device nodes are a wakeup-source even though the wakeup-source property is not defined.
Some Chromebooks use a separate wake pin, while others overload the interrupt for wake and IO. With the current assumption, spurious wakes can occur on systems that use a separate wake pin. It is planned to update the driver to no longer assume that the EC interrupt pin should be enabled for wake.
Add the wakeup-source property to all cros-ec-spi compatible device nodes to signify to the driver that they should still be a valid wakeup source.
Signed-off-by: Mark Hasemeyer <markhas@chromium.org> ---
(no changes since v3)
Changes in v3: -Update commit message to provide details of the motivation behind the change
Changes in v2: -Split by arch/soc
arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi | 1 + 1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi index f2281250ac35d..ab44d382f757e 100644 --- a/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi +++ b/arch/arm64/boot/dts/mediatek/mt8192-asurada.dtsi @@ -1332,6 +1332,7 @@ cros_ec: ec@0 { spi-max-frequency = <3000000>; pinctrl-names = "default"; pinctrl-0 = <&cros_ec_int>; + wakeup-source; #address-cells = <1>; #size-cells = <0>; -- 2.43.0.472.g3155946c3a-goog
| |