Messages in this thread | | | Date | Fri, 12 May 2023 13:18:19 +0900 | From | Mark Brown <> | Subject | Re: [PATCH v8 6/6] spi: Add support for Intel LJCA USB SPI driver |
| |
On Fri, May 12, 2023 at 01:58:44AM +0800, Ye Xiang wrote:
> +++ b/drivers/spi/spi-ljca.c > @@ -0,0 +1,290 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Intel La Jolla Cove Adapter USB-SPI driver
Please make the entire comment a C++ one so things look more intentional.
> +struct spi_init_packet { > + u8 index; > + u8 speed; > + u8 mode; > +} __packed; > + > +struct spi_xfer_packet {
These should be namespaced, especially since they look likely to collide with other things. Otherwise this looks fine. [unhandled content-type:application/pgp-signature] | |