lkml.org 
[lkml]   [2023]   [Jun]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH v8 5/6] i2c: Add support for Intel LJCA USB I2C driver
Date
Hi Oliver,

Thanks for your review.

> -----Original Message-----
> From: Oliver Neukum <oneukum@suse.com>
> Sent: Monday, May 22, 2023 5:50 PM
>
> On 11.05.23 19:58, Ye Xiang wrote:
> > Implements the I2C function of Intel USB-I2C/GPIO/SPI adapter device
> > named "La Jolla Cove Adapter" (LJCA). It communicate with LJCA I2c
> > module with specific protocol through interfaces exported by LJCA USB
> > driver.
>
> > +/* I2C Transfer */
> > +struct i2c_xfer {
> > + u8 id;
> > + u8 slave;
> > + u16 flag; /* speed, 8/16bit addr, addr increase, etc */
> > + u16 addr;
> > + u16 len;
> > + u8 data[];
> > +} __packed;
>
> Where is this needed?

Yes, you're right, we don’t need this structure. Thanks

> Why is it defined __packed, yet the internal endianness is not declared?
>
> Regards
> Oliver
\
 
 \ /
  Last update: 2023-06-20 08:57    [W:0.110 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site