Messages in this thread | | | From | Linus Walleij <> | Date | Thu, 11 May 2023 23:07:38 +0200 | Subject | Re: [PATCH v8 4/6] gpio: Add support for Intel LJCA USB GPIO driver |
| |
On Thu, May 11, 2023 at 8:01 PM Ye Xiang <xiang.ye@intel.com> wrote:
> Implements the GPIO function of Intel USB-I2C/GPIO/SPI adapter > device named "La Jolla Cove Adapter" (LJCA). It communicate with > LJCA GPIO module with specific protocol through interfaces exported > by LJCA USB driver. > > Signed-off-by: Ye Xiang <xiang.ye@intel.com>
Overall this looks very nice.
> +static int gpio_config(struct ljca_gpio_dev *ljca_gpio, u8 gpio_id, u8 config)
All other functions are prefixed ljca_* except this one, so I think you should do that on this one too.
With that fixes: Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours, Linus Walleij
| |