Messages in this thread | | | From | Michael Chan <> | Date | Tue, 7 Mar 2023 16:21:43 -0800 | Subject | Re: [PATCH 03/28] bnx2: Drop redundant pci_enable_pcie_error_reporting() |
| |
On Tue, Mar 7, 2023 at 10:20 AM Bjorn Helgaas <helgaas@kernel.org> wrote: > > From: Bjorn Helgaas <bhelgaas@google.com> > > pci_enable_pcie_error_reporting() enables the device to send ERR_* > Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is > native"), the PCI core does this for all devices during enumeration, so the > driver doesn't need to do it itself. > > Remove the redundant pci_enable_pcie_error_reporting() call from the > driver. Also remove the corresponding pci_disable_pcie_error_reporting() > from the driver .remove() path. > > Note that this only controls ERR_* Messages from the device. An ERR_* > Message may cause the Root Port to generate an interrupt, depending on the > AER Root Error Command register managed by the AER service driver. > > cd709aa90648 ("bnx2: Add PCI Advanced Error Reporting support.") added > pci_enable_pcie_error_reporting() for all devices, and c239f279e571 ("bnx2: > Enable AER on PCIE devices only") restricted it to BNX2_CHIP_5709 devices > to avoid an error message when it failed on non-PCIe devices. The PCI core > only enables PCIe error reporting on PCIe devices, which I assume means > BNX2_CHIP_5709. > > Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> > Cc: Rasesh Mody <rmody@marvell.com> > Cc: GR-Linux-NIC-Dev@marvell.com > Cc: Michael Chan <michael.chan@broadcom.com>
Reviewed-by: Michael Chan <michael.chan@broadcom.com> Thanks. [unhandled content-type:application/pkcs7-signature] | |