lkml.org 
[lkml]   [2023]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 07/28] net/fungible: Drop redundant pci_enable_pcie_error_reporting()
On Tue, Mar 7, 2023 at 10:20 AM Bjorn Helgaas <helgaas@kernel.org> wrote:
>
> From: Bjorn Helgaas <bhelgaas@google.com>
>
> pci_enable_pcie_error_reporting() enables the device to send ERR_*
> Messages. Since f26e58bf6f54 ("PCI/AER: Enable error reporting when AER is
> native"), the PCI core does this for all devices during enumeration, so the
> driver doesn't need to do it itself.
>
> Remove the redundant pci_enable_pcie_error_reporting() call from the
> driver. Also remove the corresponding pci_disable_pcie_error_reporting()
> from the driver .remove() path.
>
> Note that this only controls ERR_* Messages from the device. An ERR_*
> Message may cause the Root Port to generate an interrupt, depending on the
> AER Root Error Command register managed by the AER service driver.
>
> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
> Cc: Dimitris Michailidis <dmichail@fungible.com>

Acked-by: Dimitris Michailidis <dmichail@fungible.com>

> ---
> drivers/net/ethernet/fungible/funcore/fun_dev.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/ethernet/fungible/funcore/fun_dev.c b/drivers/net/ethernet/fungible/funcore/fun_dev.c
> index fb5120d90f26..3680f83feba2 100644
> --- a/drivers/net/ethernet/fungible/funcore/fun_dev.c
> +++ b/drivers/net/ethernet/fungible/funcore/fun_dev.c
> @@ -1,6 +1,5 @@
> // SPDX-License-Identifier: (GPL-2.0-only OR BSD-3-Clause)
>
> -#include <linux/aer.h>
> #include <linux/bitmap.h>
> #include <linux/delay.h>
> #include <linux/interrupt.h>
> @@ -748,7 +747,6 @@ void fun_dev_disable(struct fun_dev *fdev)
> pci_free_irq_vectors(pdev);
>
> pci_clear_master(pdev);
> - pci_disable_pcie_error_reporting(pdev);
> pci_disable_device(pdev);
>
> fun_unmap_bars(fdev);
> @@ -781,8 +779,6 @@ int fun_dev_enable(struct fun_dev *fdev, struct pci_dev *pdev,
> goto unmap;
> }
>
> - pci_enable_pcie_error_reporting(pdev);
> -
> rc = sanitize_dev(fdev);
> if (rc)
> goto disable_dev;
> @@ -830,7 +826,6 @@ int fun_dev_enable(struct fun_dev *fdev, struct pci_dev *pdev,
> free_irqs:
> pci_free_irq_vectors(pdev);
> disable_dev:
> - pci_disable_pcie_error_reporting(pdev);
> pci_disable_device(pdev);
> unmap:
> fun_unmap_bars(fdev);
> --
> 2.25.1
>

\
 
 \ /
  Last update: 2023-03-27 00:47    [W:0.107 / U:0.144 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site