lkml.org 
[lkml]   [2023]   [Feb]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v10 08/26] gunyah: rsc_mgr: Add resource manager RPC core
From
On 2/23/23 5:13 PM, Elliot Berman wrote:
>> TBH, gunyah.c should be merged as part of resource manager, and check
>> if uuids and features in probe before proceeding further.
>>
>
>
> Ah -- gunyah_rsc_mgr.ko has symbol dependency on gunyah-msgq.ko.
> gunyah-msgq.ko has symbol dependency on gunyah.ko. gunyah.ko doesn't
> have any probe and does all its work on module_init.
>
> In order to merge gunyah.c with resource manager, I would need to
> incorporate message queue mailbox into resource manager. IMO, this
> rapidly moves towards a mega-module which was discouraged previously.

I missed this discussion; why was it discouraged?

I can think of some reasons why I guess. But I don't see what
problem comes from linking together a "mega module" that's made
up of well-isolated source files that expose minimal APIs to
one another. All inter-dependent modules will required at once
anyway; I don't understand the benefit of implementing them
separately. Can you explain, or provide some context? Thanks.

-Alex

\
 
 \ /
  Last update: 2023-03-27 00:37    [W:0.489 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site