Messages in this thread | | | Date | Thu, 23 Feb 2023 10:29:20 +0000 | Subject | Re: [PATCH v10 08/26] gunyah: rsc_mgr: Add resource manager RPC core | From | Srinivas Kandagatla <> |
| |
On 22/02/2023 23:18, Elliot Berman wrote: >>> >>> +EXPORT_SYMBOL_GPL(gh_rm_notifier_unregister); >>> + >>> +void get_gh_rm(struct gh_rm *rm) >>> +{ >>> + get_device(rm->dev); >>> +} >>> +EXPORT_SYMBOL_GPL(get_gh_rm); >> >> Can we have some consistency in the exported symbol naming, >> we have two combinations now. >> >> EXPORT_SYMBOL_GPL(gh_rm_notifier_register); >> EXPORT_SYMBOL_GPL(get_gh_rm); >> >> lets stick to one. > > done. > >>> + >>> +void put_gh_rm(struct gh_rm *rm) >>> +{ >>> + put_device(rm->dev); >>> +} >>> +EXPORT_SYMBOL_GPL(put_gh_rm); >>> >> ... >> >>> + >>> +static int gh_rm_drv_probe(struct platform_device *pdev) >>> +{ >>> + struct gh_msgq_tx_data *msg; >>> + struct gh_rm *rm; >>> + int ret; >>> + >> How are we ensuring that gunyah driver is probed before this driver? >> >> > > Which driver?
Am referring to gunyah.ko
TBH, gunyah.c should be merged as part of resource manager, and check if uuids and features in probe before proceeding further.
-srini
> >>> + rm = devm_kzalloc(&pdev->dev, sizeof(*rm), GFP_KERNEL); >>> + if (!rm) >>> + return -ENOMEM; >>> + >>> + platform_set_drvdata(pdev, rm); >>> + rm->dev = &pdev->dev; >>> + >>> + mutex_init(&rm->call_idr_lock); >>> + idr_init(&rm->call_idr); >>> + rm->cache = kmem_cache_create("gh_rm", struct_size(msg, data, >>> GH_MSGQ_MAX_MSG_SIZE), 0, >>> + SLAB_HWCACHE_ALIGN, NULL); >>> + if (!rm->cache) >>> + return -ENOMEM; >> new line here would be nice. >> > > done.
| |