Messages in this thread | | | Date | Thu, 23 Feb 2023 15:13:20 -0800 | Subject | Re: [PATCH v10 08/26] gunyah: rsc_mgr: Add resource manager RPC core | From | Elliot Berman <> |
| |
On 2/23/2023 2:29 AM, Srinivas Kandagatla wrote: > > > On 22/02/2023 23:18, Elliot Berman wrote: >>>> >>>> +EXPORT_SYMBOL_GPL(gh_rm_notifier_unregister); >>>> + >>>> +void get_gh_rm(struct gh_rm *rm) >>>> +{ >>>> + get_device(rm->dev); >>>> +} >>>> +EXPORT_SYMBOL_GPL(get_gh_rm); >>> >>> Can we have some consistency in the exported symbol naming, >>> we have two combinations now. >>> >>> EXPORT_SYMBOL_GPL(gh_rm_notifier_register); >>> EXPORT_SYMBOL_GPL(get_gh_rm); >>> >>> lets stick to one. >> >> done. >> >>>> + >>>> +void put_gh_rm(struct gh_rm *rm) >>>> +{ >>>> + put_device(rm->dev); >>>> +} >>>> +EXPORT_SYMBOL_GPL(put_gh_rm); >>>> >>> ... >>> >>>> + >>>> +static int gh_rm_drv_probe(struct platform_device *pdev) >>>> +{ >>>> + struct gh_msgq_tx_data *msg; >>>> + struct gh_rm *rm; >>>> + int ret; >>>> + >>> How are we ensuring that gunyah driver is probed before this driver? >>> >>> >> >> Which driver? > > Am referring to gunyah.ko > > TBH, gunyah.c should be merged as part of resource manager, and check if > uuids and features in probe before proceeding further. >
Ah -- gunyah_rsc_mgr.ko has symbol dependency on gunyah-msgq.ko. gunyah-msgq.ko has symbol dependency on gunyah.ko. gunyah.ko doesn't have any probe and does all its work on module_init.
In order to merge gunyah.c with resource manager, I would need to incorporate message queue mailbox into resource manager. IMO, this rapidly moves towards a mega-module which was discouraged previously.
Thanks, Elliot
| |