lkml.org 
[lkml]   [2023]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RFC v2 for-6.8/block 01/18] block: add some bdev apis
From
Date
Hi,

在 2023/12/12 21:16, Christoph Hellwig 写道:
>> +void invalidate_bdev_range(struct block_device *bdev, pgoff_t start,
>> + pgoff_t end)
>> +{
>> + invalidate_mapping_pages(bdev->bd_inode->i_mapping, start, end);
>> +}
>> +EXPORT_SYMBOL_GPL(invalidate_bdev_range);
>
> Can we have kerneldoc comments for the new helpers please?

Of course, will definitely do this in v3.
>
>> +struct folio *__bdev_get_folio(struct block_device *bdev, loff_t pos,
>> + fgf_t fgp_flags, gfp_t gfp)
>> +{
>> + return __filemap_get_folio(bdev->bd_inode->i_mapping, pos >> PAGE_SHIFT,
>> + fgp_flags, gfp);
>> +}
>> +EXPORT_SYMBOL_GPL(__bdev_get_folio);
>
> It's a bit silly to have a __-prefixed API without a version that
> doesn't have the prefix, so I'd prefer to drop it. Unless willy has
> a good argument for keeping it the same as the filemap API.

Ok, I'll drop it if willy doesn't against this.

Thanks,
Kuai
>
> .
>

\
 
 \ /
  Last update: 2023-12-13 02:09    [W:0.086 / U:1.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site