Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 11 Dec 2023 17:52:17 +0100 | From | Jan Kara <> | Subject | Re: [PATCH RFC v2 for-6.8/block 01/18] block: add some bdev apis |
| |
On Mon 11-12-23 22:05:35, Yu Kuai wrote: > From: Yu Kuai <yukuai3@huawei.com> > > Those apis will be used for other modules, so that bd_inode won't be > accessed directly from other modules. > > Signed-off-by: Yu Kuai <yukuai3@huawei.com>
...
> +void bdev_associated_mapping(struct block_device *bdev, > + struct address_space *mapping) > +{ > + mapping->host = bdev->bd_inode; > +}
Here I'm not sure - is the helper really a win? It seems a bit obscure to me. This initialization of another mapping for a bdev looks really special.
Honza -- Jan Kara <jack@suse.com> SUSE Labs, CR
| ![\](/images/icornerr.gif) |