Messages in this thread | ![/](/images/icornerl.gif) | | Subject | Re: [PATCH RFC v2 for-6.8/block 01/18] block: add some bdev apis | From | Yu Kuai <> | Date | Tue, 12 Dec 2023 09:25:24 +0800 |
| |
Hi,
在 2023/12/12 0:52, Jan Kara 写道: > On Mon 11-12-23 22:05:35, Yu Kuai wrote: >> From: Yu Kuai <yukuai3@huawei.com> >> >> Those apis will be used for other modules, so that bd_inode won't be >> accessed directly from other modules. >> >> Signed-off-by: Yu Kuai <yukuai3@huawei.com> > > ... > >> +void bdev_associated_mapping(struct block_device *bdev, >> + struct address_space *mapping) >> +{ >> + mapping->host = bdev->bd_inode; >> +} > > Here I'm not sure - is the helper really a win? It seems a bit obscure to > me. This initialization of another mapping for a bdev looks really special.
Yes, I don't like this helper at all, but gfs2 is used this way, and I need this helper to remove 'bd_inode' from block_devcie later. I'm not familiar with gfs2 at all but perhaps it worth to dig deeper and figure out a proper way for gfs2.
Thanks, Kuai > > Honza >
| ![\](/images/icornerr.gif) |