lkml.org 
[lkml]   [2023]   [Jan]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v8 05/16] x86/virt/tdx: Implement functions to make SEAMCALL
From
The subject here is a bit too specific.  This patch isn't just
"implementing functions". There are more than just functions here. The
best subject is probably:

Add SEAMCALL infrastructure

But that's rather generic by necessity because this patch does several
_different_ logical things:

* Wrap TDX_MODULE_CALL so it can be used for SEAMCALLs with host=1
* Add handling to TDX_MODULE_CALL to allow it to handle specifically
host-side error conditions
* Add high-level seamcall() function with actual error handling

It's probably also worth noting that the code that allows "host=1" to be
passed to TDX_MODULE_CALL is dead code in mainline right now. It
probably shouldn't have been merged this way, but oh well.

I don't know that you really _need_ to split this up, but I'm just
pointing out that mashing three different logical things together makes
it hard to write a coherent Subject. But, I've seen worse.

\
 
 \ /
  Last update: 2023-03-26 23:31    [W:0.848 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site