lkml.org 
[lkml]   [2023]   [Jan]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH v8 10/16] x86/virt/tdx: Allocate and set up PAMTs for TDMRs
    Date
    On Fri, 2023-01-06 at 13:53 -0800, Dave Hansen wrote:
    > Looks good so far.
    >
    > > +/*
    > > + * Allocate PAMTs from the local NUMA node of some memory in @tmb_list
    > > + * within @tdmr, and set up PAMTs for @tdmr.
    > > + */
    > > +static int tdmr_set_up_pamt(struct tdmr_info *tdmr,
    > > + struct list_head *tmb_list,
    > > + u16 pamt_entry_size)
    > > +{
    > > + unsigned long pamt_base[TDX_PS_1G + 1];
    > > + unsigned long pamt_size[TDX_PS_1G + 1];
    >
    > Nit: please define a TDX_PS_NR rather than open-coding this.

    Will do.

    >
    > > + unsigned long tdmr_pamt_base;
    > > + unsigned long tdmr_pamt_size;
    > > + struct page *pamt;
    > > + int pgsz, nid;
    > > +
    > > + nid = tdmr_get_nid(tdmr, tmb_list);
    > > +
    > > + /*
    > > + * Calculate the PAMT size for each TDX supported page size
    > > + * and the total PAMT size.
    > > + */
    > > + tdmr_pamt_size = 0;
    > > + for (pgsz = TDX_PS_4K; pgsz <= TDX_PS_1G ; pgsz++) {
    > > + pamt_size[pgsz] = tdmr_get_pamt_sz(tdmr, pgsz,
    > > + pamt_entry_size);
    >
    > This alignment is wonky. Should be way over here:
    >
    > > + pamt_entry_size);

    Will do.

    >
    > > + tdmr_pamt_size += pamt_size[pgsz];
    > > + }
    > > +
    > >

    [snip]

    >
    > Other than the two nits:
    >
    > Reviewed-by: Dave Hansen <dave.hansen@linux.intel.com>
    >

    Thanks.

    \
     
     \ /
      Last update: 2023-03-26 23:34    [W:4.069 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site