Messages in this thread | | | Date | Mon, 23 Jan 2023 11:08:28 +0000 | Subject | Re: [PATCH v4 0/6] Add MSM8939 SoC support with two devices | From | Bryan O'Donoghue <> |
| |
On 23/01/2023 02:31, Bryan O'Donoghue wrote: > V4: > - Adds Krzysztof's RB to snoc-mm > - Re-orders alphabetically missed nodes in previous iteration - Bjorn > - Adds LK address/size cells comment - Bjorn > > - Left _AO for wcnss as downstream reference uses this - Bjorn/Bryan > - Uses qcom,ids.h and QCOM_ID_SOCNAME for qcom,msm-id - Bjorn > - Revises comment from "Regulator" to "Power supply" - Bjorn > - Leaves dummy power-domain reference in cpu defintion as this > > - Relabels "cpu" to "CPU" to be more consistent with other dtsi - Bryan > - Moves msm8939 gcc to its own yaml file to capture 8939 specific form - Bryan > > is a required property and the dt checker complains - Stephan/Bryan > - Removes CPR entries from qfprom - Stephan > - Left MDSS interconnects. I don't see a bug to fix here - Stephan/Bryan > - power-domain in MDSS - dropped its not longer required after > commit a6f033938beb ("dt-bindings: msm: dsi-controller-main: Fix power-domain constraint") - Stephan > - Adds gcc dsi1pll and dsi1pllbyte to gcc clock list. > Reviewing the silicon documentation we see dsi0_phy_pll is used to clock > GCC_BYTE1_CFG_RCGR : SRC_SEL > Root Source Select > 000 : cxo > 001 : dsi0_phy_pll_out_byteclk > 010 : GPLL0_OUT_AUX > 011 : gnd > 100 : gnd > 101 : gnd > 110 : gnd > 111 : reserved - Stephan/Bryan > > - pm8916_l16 -> pm8916_l6 in dsi definition, typo - Konrad > - Moved regulator_set_load location - Konrad > > Previous:https://lore.kernel.org/lkml/20230118050948.bibhq26s6sgzullg@builder.lan/T/ > Bootable:https://git.linaro.org/people/bryan.odonoghue/kernel.git/log/?h=linux-next-23-01-23-msm8939-nocpr
Let me translate my 2:30 am email to english, I meant to group this by reviewer
V4: - Adds Krzysztof's RB to snoc-mm
- Re-orders alphabetically missed nodes in previous iteration - Bjorn - Adds LK address/size cells comment - Bjorn - Left _AO for wcnss as downstream reference uses this - Bjorn/Bryan - Uses qcom,ids.h and QCOM_ID_SOCNAME for qcom,msm-id - Bjorn - Revises comment from "Regulator" to "Power supply" - Bjorn - Leaves dummy power-domain reference in cpu defintion as this is a required property and the dt checker complains - Stephan/Bryan
- Relabels "cpu" to "CPU" to be more consistent with other dtsi - Bryan - Moves msm8939 gcc to its own yaml file to 8939 specifics -Bryan
- Removes CPR entries from qfprom - Stephan - Left MDSS interconnects. I don't see a bug to fix here - Stephan/Bryan - power-domain in MDSS - dropped its not longer required after commit a6f033938beb ("dt-bindings: msm: dsi-controller-main: Fix power-domain constraint") - Stephan - Adds gcc dsi1pll and dsi1pllbyte to gcc clock list. Reviewing the silicon documentation we see dsi0_phy_pll is used to clock GCC_BYTE1_CFG_RCGR : SRC_SEL Root Source Select 000 : cxo 001 : dsi0_phy_pll_out_byteclk 010 : GPLL0_OUT_AUX 011 : gnd 100 : gnd 101 : gnd 110 : gnd 111 : reserved - Stephan/Bryan
- pm8916_l16 -> pm8916_l6 in dsi definition, typo - Konrad - Moved regulator_set_load location - Konrad
| |