Messages in this thread | | | Subject | Re: [PATCH v2 13/17] coresight: trbe: Add a helper to determine the minimum buffer size | From | Anshuman Khandual <> | Date | Wed, 22 Sep 2021 15:21:49 +0530 |
| |
On 9/21/21 7:11 PM, Suzuki K Poulose wrote: > For the TRBE to operate, we need a minimum space available to collect > meaningful trace session. This is currently a few bytes, but we may need > to extend this for working around errata. So, abstract this into a helper > function. > > Cc: Anshuman Khandual <anshuman.khandual@arm.com> > Cc: Mike Leach <mike.leach@linaro.org> > Cc: Mathieu Poirier <mathieu.poirier@linaro.org> > Cc: Leo Yan <leo.yan@linaro.org> > Signed-off-by: Suzuki K Poulose <suzuki.poulose@arm.com> > --- > drivers/hwtracing/coresight/coresight-trbe.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-trbe.c b/drivers/hwtracing/coresight/coresight-trbe.c > index 797d978f9fa7..3373f4e2183b 100644 > --- a/drivers/hwtracing/coresight/coresight-trbe.c > +++ b/drivers/hwtracing/coresight/coresight-trbe.c > @@ -277,6 +277,11 @@ trbe_handle_to_cpudata(struct perf_output_handle *handle) > return buf->cpudata; > } > > +static u64 trbe_min_trace_buf_size(struct perf_output_handle *handle) > +{ > + return TRBE_TRACE_MIN_BUF_SIZE; > +}
Assuming that struct perf_output_handle could provide all the required support for a variable minimum trace buffer length.
Reviewed-by: Anshuman Khandual <anshuman.khandual@arm.com>
> + > /* > * TRBE Limit Calculation > * > @@ -447,7 +452,7 @@ static unsigned long trbe_normal_offset(struct perf_output_handle *handle) > * have space for a meaningful run, we rather pad it > * and start fresh. > */ > - if (limit && (limit - head < TRBE_TRACE_MIN_BUF_SIZE)) { > + if (limit && ((limit - head) < trbe_min_trace_buf_size(handle))) { > trbe_pad_buf(handle, limit - head); > limit = __trbe_normal_offset(handle); > } >
| |