lkml.org 
[lkml]   [2021]   [Jul]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH -tip v8 03/13] kprobes: treewide: Remove trampoline_address from kretprobe_trampoline_handler()

    * Masami Hiramatsu <mhiramat@kernel.org> wrote:

    > --- a/include/linux/kprobes.h
    > +++ b/include/linux/kprobes.h
    > @@ -197,15 +197,23 @@ extern void arch_prepare_kretprobe(struct kretprobe_instance *ri,
    > struct pt_regs *regs);
    > extern int arch_trampoline_kprobe(struct kprobe *p);
    >
    > +void kretprobe_trampoline(void);
    > +/*
    > + * Since some architecture uses structured function pointer,
    > + * use dereference_function_descriptor() to get real function address.
    > + */
    > +static nokprobe_inline void *kretprobe_trampoline_addr(void)
    > +{
    > + return dereference_kernel_function_descriptor(kretprobe_trampoline);
    > +}

    Could we please also make 'kretprobe_trampoline' harder to use
    accidentally, such by naming it appropriately?

    __kretprobe_trampoline would be a good first step I guess.

    Thanks,

    Ingo

    \
     
     \ /
      Last update: 2021-07-05 09:04    [W:2.247 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site