lkml.org 
[lkml]   [2021]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH -next v2] media: staging: atomisp: use list_move_tail instead of list_del/list_add_tail in atomisp_compat_css20.c
Date
Using list_move_tail() instead of list_del() + list_add_tail() in atomisp_compat_css20.c.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Baokun Li <libaokun1@huawei.com>
---
V1->V2:
CC mailist

.../pci/atomisp_compat_css20.c | 15 +++++----------
1 file changed, 5 insertions(+), 10 deletions(-)

diff --git a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
index f60198bb8a1a..3bd4c616655d 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_compat_css20.c
@@ -2147,22 +2147,19 @@ void atomisp_css_stop(struct atomisp_sub_device *asd,
while (!list_empty(&asd->s3a_stats_in_css)) {
s3a_buf = list_entry(asd->s3a_stats_in_css.next,
struct atomisp_s3a_buf, list);
- list_del(&s3a_buf->list);
- list_add_tail(&s3a_buf->list, &asd->s3a_stats);
+ list_move_tail(&s3a_buf->list, &asd->s3a_stats);
}
while (!list_empty(&asd->s3a_stats_ready)) {
s3a_buf = list_entry(asd->s3a_stats_ready.next,
struct atomisp_s3a_buf, list);
- list_del(&s3a_buf->list);
- list_add_tail(&s3a_buf->list, &asd->s3a_stats);
+ list_move_tail(&s3a_buf->list, &asd->s3a_stats);
}

spin_lock_irqsave(&asd->dis_stats_lock, irqflags);
while (!list_empty(&asd->dis_stats_in_css)) {
dis_buf = list_entry(asd->dis_stats_in_css.next,
struct atomisp_dis_buf, list);
- list_del(&dis_buf->list);
- list_add_tail(&dis_buf->list, &asd->dis_stats);
+ list_move_tail(&dis_buf->list, &asd->dis_stats);
}
asd->params.dis_proj_data_valid = false;
spin_unlock_irqrestore(&asd->dis_stats_lock, irqflags);
@@ -2171,14 +2168,12 @@ void atomisp_css_stop(struct atomisp_sub_device *asd,
while (!list_empty(&asd->metadata_in_css[i])) {
md_buf = list_entry(asd->metadata_in_css[i].next,
struct atomisp_metadata_buf, list);
- list_del(&md_buf->list);
- list_add_tail(&md_buf->list, &asd->metadata[i]);
+ list_move_tail(&md_buf->list, &asd->metadata[i]);
}
while (!list_empty(&asd->metadata_ready[i])) {
md_buf = list_entry(asd->metadata_ready[i].next,
struct atomisp_metadata_buf, list);
- list_del(&md_buf->list);
- list_add_tail(&md_buf->list, &asd->metadata[i]);
+ list_move_tail(&md_buf->list, &asd->metadata[i]);
}
}

\
 
 \ /
  Last update: 2021-06-09 09:15    [W:0.805 / U:1.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site