lkml.org 
[lkml]   [2021]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH -next v2] media: staging: atomisp: use list_move_tail instead of list_del/list_add_tail in atomisp_compat_css20.c
On Wed, Jun 9, 2021 at 4:32 PM Baokun Li <libaokun1@huawei.com> wrote:
>
> Using list_move_tail() instead of list_del() + list_add_tail() in atomisp_compat_css20.c.

Have you considered using list_splice() instead of entire while-loops?
Or something similar from list.h...

> while (!list_empty(&asd->s3a_stats_in_css)) {
> s3a_buf = list_entry(asd->s3a_stats_in_css.next,
> struct atomisp_s3a_buf, list);
> - list_del(&s3a_buf->list);
> - list_add_tail(&s3a_buf->list, &asd->s3a_stats);
> + list_move_tail(&s3a_buf->list, &asd->s3a_stats);
> }
> while (!list_empty(&asd->s3a_stats_ready)) {
> s3a_buf = list_entry(asd->s3a_stats_ready.next,
> struct atomisp_s3a_buf, list);
> - list_del(&s3a_buf->list);
> - list_add_tail(&s3a_buf->list, &asd->s3a_stats);
> + list_move_tail(&s3a_buf->list, &asd->s3a_stats);
> }

> while (!list_empty(&asd->dis_stats_in_css)) {
> dis_buf = list_entry(asd->dis_stats_in_css.next,
> struct atomisp_dis_buf, list);
> - list_del(&dis_buf->list);
> - list_add_tail(&dis_buf->list, &asd->dis_stats);
> + list_move_tail(&dis_buf->list, &asd->dis_stats);
> }

> while (!list_empty(&asd->metadata_in_css[i])) {
> md_buf = list_entry(asd->metadata_in_css[i].next,
> struct atomisp_metadata_buf, list);
> - list_del(&md_buf->list);
> - list_add_tail(&md_buf->list, &asd->metadata[i]);
> + list_move_tail(&md_buf->list, &asd->metadata[i]);
> }
> while (!list_empty(&asd->metadata_ready[i])) {
> md_buf = list_entry(asd->metadata_ready[i].next,
> struct atomisp_metadata_buf, list);
> - list_del(&md_buf->list);
> - list_add_tail(&md_buf->list, &asd->metadata[i]);
> + list_move_tail(&md_buf->list, &asd->metadata[i]);
> }

--
With Best Regards,
Andy Shevchenko

\
 
 \ /
  Last update: 2021-06-09 20:18    [W:0.036 / U:0.124 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site