lkml.org 
[lkml]   [2021]   [Mar]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH 03/17] ASoC: atmel: atmel-i2s: remove useless initialization
Date
On 26.03.2021 23:59, Pierre-Louis Bossart wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> Cppcheck complains:
>
> sound/soc/atmel/atmel-i2s.c:628:6: style: Redundant initialization for 'err'. The initialized value is overwritten before it is read. [redundantInitialization]
> err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0,
> ^
> sound/soc/atmel/atmel-i2s.c:598:10: note: err is initialized
> int err = -ENXIO;
> ^
> sound/soc/atmel/atmel-i2s.c:628:6: note: err is overwritten
> err = devm_request_irq(&pdev->dev, irq, atmel_i2s_interrupt, 0,
> ^
>
> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Thanks!
\
 
 \ /
  Last update: 2021-03-29 09:33    [W:0.151 / U:0.116 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site