Messages in this thread | | | Date | Mon, 29 Mar 2021 09:14:35 +0200 | From | Thierry Reding <> | Subject | Re: [PATCH 12/17] ASoC: tegra: tegra20_das: clarify expression |
| |
On Fri, Mar 26, 2021 at 04:59:22PM -0500, Pierre-Louis Bossart wrote: > cppcheck warning: > > sound/soc/tegra/tegra20_das.c:64:60: style: Boolean result is used in > bitwise operation. Clarify expression with > parentheses. [clarifyCondition] > reg = otherdap << TEGRA20_DAS_DAP_CTRL_SEL_DAP_CTRL_SEL_P | > ^ > sound/soc/tegra/tegra20_das.c:65:61: style: Boolean result is used in > bitwise operation. Clarify expression with > parentheses. [clarifyCondition] > > !!sdata2rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA2_TX_RX_P | > ^ > sound/soc/tegra/tegra20_das.c:66:61: style: Boolean result is used in > bitwise operation. Clarify expression with > parentheses. [clarifyCondition] > !!sdata1rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA1_TX_RX_P | > ^ > > Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> > --- > sound/soc/tegra/tegra20_das.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-)
Acked-by: Thierry Reding <treding@nvidia.com> [unhandled content-type:application/pgp-signature] | |