lkml.org 
[lkml]   [2021]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 12/17] ASoC: tegra: tegra20_das: clarify expression
    Date
    cppcheck warning:

    sound/soc/tegra/tegra20_das.c:64:60: style: Boolean result is used in
    bitwise operation. Clarify expression with
    parentheses. [clarifyCondition]
    reg = otherdap << TEGRA20_DAS_DAP_CTRL_SEL_DAP_CTRL_SEL_P |
    ^
    sound/soc/tegra/tegra20_das.c:65:61: style: Boolean result is used in
    bitwise operation. Clarify expression with
    parentheses. [clarifyCondition]

    !!sdata2rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA2_TX_RX_P |
    ^
    sound/soc/tegra/tegra20_das.c:66:61: style: Boolean result is used in
    bitwise operation. Clarify expression with
    parentheses. [clarifyCondition]
    !!sdata1rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA1_TX_RX_P |
    ^

    Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
    ---
    sound/soc/tegra/tegra20_das.c | 8 ++++----
    1 file changed, 4 insertions(+), 4 deletions(-)

    diff --git a/sound/soc/tegra/tegra20_das.c b/sound/soc/tegra/tegra20_das.c
    index 79dba878d854..69c651274c12 100644
    --- a/sound/soc/tegra/tegra20_das.c
    +++ b/sound/soc/tegra/tegra20_das.c
    @@ -61,10 +61,10 @@ int tegra20_das_connect_dap_to_dap(int dap, int otherdap, int master,

    addr = TEGRA20_DAS_DAP_CTRL_SEL +
    (dap * TEGRA20_DAS_DAP_CTRL_SEL_STRIDE);
    - reg = otherdap << TEGRA20_DAS_DAP_CTRL_SEL_DAP_CTRL_SEL_P |
    - !!sdata2rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA2_TX_RX_P |
    - !!sdata1rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA1_TX_RX_P |
    - !!master << TEGRA20_DAS_DAP_CTRL_SEL_DAP_MS_SEL_P;
    + reg = (otherdap << TEGRA20_DAS_DAP_CTRL_SEL_DAP_CTRL_SEL_P) |
    + (!!sdata2rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA2_TX_RX_P) |
    + (!!sdata1rx << TEGRA20_DAS_DAP_CTRL_SEL_DAP_SDATA1_TX_RX_P) |
    + (!!master << TEGRA20_DAS_DAP_CTRL_SEL_DAP_MS_SEL_P);

    tegra20_das_write(addr, reg);

    --
    2.25.1
    \
     
     \ /
      Last update: 2021-03-26 23:01    [W:3.725 / U:0.116 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site