| Date | Wed, 10 Mar 2021 17:14:19 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH v1 2/7] PCI: Convert __pci_read_base() to __pci_bus_read_base() |
| |
> +static inline > int __pci_read_base(struct pci_dev *dev, enum pci_bar_type type, > + struct resource *res, unsigned int reg)
This looks weird. Normal kernel style would be:
static inline int __pci_read_base(struct pci_dev *dev, enum pci_bar_type type, struct resource *res, unsigned int reg)
or
static inline int __pci_read_base(struct pci_dev *dev, enum pci_bar_type type,
that being said, there seems to be no good agument to even make this and inline function.
> + return __pci_bus_read_base(dev->bus, dev->devfn, type, res, reg, dev->mmio_always_on);
Please avoid pointless overly long lines.
|