Messages in this thread | | | Date | Tue, 9 Feb 2021 15:54:00 -0600 | From | Rob Herring <> | Subject | Re: [PATCH v2 03/24] dt-bindings: net: dwmac: Fix the TSO property declaration |
| |
On Mon, 08 Feb 2021 16:55:47 +0300, Serge Semin wrote: > Indeed the STMMAC driver doesn't take the vendor-specific compatible > string into account to parse the "snps,tso" boolean property. It just > makes sure the node is compatible with DW MAC 4.x, 5.x and DW xGMAC > IP-cores. The original allwinner sunXi bindings file also didn't have the > TSO-related property declared. Taking all of that into account fix the > conditional statement so the TSO-property would be evaluated for the > compatibles having the corresponding IP-core version. > > While at it move the whole allOf-block from the tail of the binding file > to the head of it, as it's normally done in the most of the DT schemas. > > Signed-off-by: Serge Semin <Sergey.Semin@baikalelectronics.ru> > > --- > > Note this won't break the bindings description, since the "snps,tso" > property isn't parsed by the Allwinner SunX GMAC glue driver, but only > by the generic platform DT-parser. > > Changelog v2: > - Use correct syntax of the JSON pointers, so the later would begin > with a '/' after the '#'. > --- > .../devicetree/bindings/net/snps,dwmac.yaml | 52 +++++++++---------- > 1 file changed, 24 insertions(+), 28 deletions(-) >
Reviewed-by: Rob Herring <robh@kernel.org>
| |