Messages in this thread | | | From | "Limonciello, Mario" <> | Subject | RE: [PATCH v5] Introduce support for Systems Management Driver over WMI for Dell Systems | Date | Wed, 30 Sep 2020 21:02:38 +0000 |
| |
> > + possible_values: A file that can be read to obtain the possible > > + values of the <attr>. Values are separated using > > + semi-colon (``;``). > why not use set notation from math classes assuming intergers? i.e. > (a, b) all integers beween a and b but not including a or b (open set) > or > [a, b] all integerger betwen a and b including and b? (closed set) > > Anyway its ambiguous if the the extremes are included in the set of possible > values as written. >
Enumeration attributes mean that there are fixed values, specifically not integers. Integers are in the "integer" type and explained below.
An example value that would be seen here is possible_values:
Enabled;Disabled;
> > + > > + security_area_size = calculate_security_buffer(); > > + buffer_size = security_area_size + integer_area_size; > > + buffer = kzalloc(buffer_size, GFP_KERNEL); > > + if (!buffer) > > + return -ENOMEM; > if you hit this error return I think you will leak the wmi_priv.mutex lock. > I think this is a bug.
Yes, thanks this is a great finding. Team will fix in v6 after we have Hans' feedback for v5.
| |