lkml.org 
[lkml]   [2020]   [Feb]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 1/5 V2] staging: iio: adc: ad7192: fail probe on get_voltage
Date
This patch makes the ad7192_probe fail in case
regulator_get_voltage will return an error.

Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com>
---
drivers/staging/iio/adc/ad7192.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/iio/adc/ad7192.c b/drivers/staging/iio/adc/ad7192.c
index bf3e2a9cc07f..4780ddf99b13 100644
--- a/drivers/staging/iio/adc/ad7192.c
+++ b/drivers/staging/iio/adc/ad7192.c
@@ -899,10 +899,13 @@ static int ad7192_probe(struct spi_device *spi)

voltage_uv = regulator_get_voltage(st->avdd);

- if (voltage_uv)
+ if (voltage_uv) {
st->int_vref_mv = voltage_uv / 1000;
- else
+ } else {
+ ret = voltage_uv;
dev_err(&spi->dev, "Device tree error, reference voltage undefined\n");
+ goto error_disable_avdd;
+ }

spi_set_drvdata(spi, indio_dev);
st->devid = spi_get_device_id(spi)->driver_data;
@@ -957,6 +960,7 @@ static int ad7192_probe(struct spi_device *spi)
ret = iio_device_register(indio_dev);
if (ret < 0)
goto error_disable_clk;
+
return 0;

error_disable_clk:
--
2.20.1
\
 
 \ /
  Last update: 2020-02-05 18:16    [W:0.052 / U:0.996 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site