[lkml]   [2020]   [Feb]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
Subject[PATCH v3 0/4] Add support for devices in the Energy Model
Hi all,

This patch set introduces support for devices in the Energy Model (EM)
framework. It will unify the power model for thermal subsystem and make it
simpler. The 1st patch refactors EM framework and adds support for devices.
The 2nd patch changes dev_pm_opp_of_register_em() in OPP/OF which now should
take as an argument struct device pointer. It touches a few trees
(OMAP, NXP, Mediatek) updating their CPUfreq drivers to the new interface.
Patch 3/4 changes thermal devfreq cooling removing old code for calculating
local power table. It simplifies the code and uses EM for requested power
calculation. Last patch 4/4 adds EM to Panfrost driver.

The patch set is based on linux-next tag next-20200221.

- added back the cpumask 'cpus' in the em_perf_domain due potential cache misses
- removed _is_cpu_em() since there is no need for it
- changed function name from em_pd_energy() to em_cpu_energy(), which is
optimized for usage from the scheduler making some assumptions and not
validating arguments to speed-up, there is a comment stressing that it should
be used only for CPUs em_perf_domain
- changed em_get_pd() to em_pd_get() which is now aligned with em_cpu_get()
- extended comment in em_cpu_get() describing the need for this function
- fixed build warning reported on x86 by kbuild test robot in devfreq_cooling.c
- updated documentation in the energy-model.rst
- changed print messages from 'energy_model' to 'EM'
- changed dev_warn to dev_dbg, should calm down test scripts in case the
platform has OPPs less efficient in the OPP table (some of them are there for
cooling reasons, we shouldn't warn in this case, debug info is enough)

v2 [2]:
- changed EM API em_register_perf_domain() adding cpumask_t pointer
as last argument (which was discussed with Dietmar and Quentin)
- removed dependency on PM_OPP, thanks to the cpumask_t argument
- removed enum em_type and em->type dependent code
- em_get_pd() can handle CPU device as well as devfreq device
- updated EM documentation
- in devfreq cooling added code which prevents from race condition with
devfreq governors which are trying to use OPPs while thermal is in the middle
of disabling them.
- in devfreq cooling added code which updates state of the devfreq device to
avoid working on stale data when governor has not updated it for a long time
- in devfreq cooling added backward compatibility frequency table for drivers
which did not provide EM
- added Steven's Reviewed-by to trace code in thermal
- added another CPUFreq driver which needs to be updated to the new API

The v1 can be found here [1].

Lukasz Luba


Lukasz Luba (4):
PM / EM: add devices to Energy Model
OPP: change parameter to device pointer in dev_pm_opp_of_register_em()
thermal: devfreq_cooling: Refactor code and switch to use Energy Model
drm/panfrost: Register to the Energy Model with devfreq device

Documentation/power/energy-model.rst | 133 +++---
Documentation/scheduler/sched-energy.rst | 2 +-
drivers/cpufreq/cpufreq-dt.c | 2 +-
drivers/cpufreq/imx6q-cpufreq.c | 2 +-
drivers/cpufreq/mediatek-cpufreq.c | 2 +-
drivers/cpufreq/omap-cpufreq.c | 2 +-
drivers/cpufreq/qcom-cpufreq-hw.c | 2 +-
drivers/cpufreq/scmi-cpufreq.c | 11 +-
drivers/cpufreq/scpi-cpufreq.c | 2 +-
drivers/cpufreq/vexpress-spc-cpufreq.c | 2 +-
drivers/gpu/drm/panfrost/panfrost_devfreq.c | 3 +
drivers/opp/of.c | 45 +--
drivers/thermal/cpufreq_cooling.c | 10 +-
drivers/thermal/devfreq_cooling.c | 425 +++++++++-----------
include/linux/devfreq_cooling.h | 17 -
include/linux/energy_model.h | 107 +++--
include/linux/pm_opp.h | 14 +-
include/trace/events/thermal.h | 19 +-
kernel/power/energy_model.c | 400 ++++++++++++++----
kernel/sched/fair.c | 2 +-
kernel/sched/topology.c | 4 +-
21 files changed, 711 insertions(+), 495 deletions(-)


 \ /
  Last update: 2020-02-21 20:49    [W:0.054 / U:0.180 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site